[Openmp-commits] [PATCH] D144419: Improvements to the OpenMP Windows build

Tue Feb 21 05:46:58 PST 2023

hans added a comment.

In D144419#4139886 <https://reviews.llvm.org/D144419#4139886>, @mstorsjo wrote:

> CC @hans @pbo-linaro @omjavaid - does this break anything for your Windows releases (which I believe some are built with clang-cl, and some which do include OpenMP)?

Yes, I just tried the script and the release build does indeed seem to be broken because of openmp.

> Although I guess it's possible to build with something like `-DCMAKE_AR=lib.exe` to force a preference for the tool which does support the `/def` option.

Just `-DCMAKE_AR=lib.exe` doesn't seem to work, as it needs the full path.

Patches welcome for that, or for implementing `llvm-lib /def:` support. Should we revert D143431 <https://reviews.llvm.org/D143431> in the meantime?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144419/new/

https://reviews.llvm.org/D144419