[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in amdgpu plugin

Fri Feb 10 09:31:11 PST 2023

dhruvachak added inline comments.

================
Comment at: openmp/libomptarget/plugins/amdgpu/src/ompt_callback.cpp:22
+/// Object maintaining all the callbacks in the plugin
+OmptDeviceCallbacksTy ompt_device_callbacks;
+
----------------
We use OmptDeviceCallbacks variable name in libomptarget. Let's keep it consistent. 

================
Comment at: openmp/libomptarget/plugins/amdgpu/src/ompt_callback.cpp:35
+
+#ifdef OMPT_SUPPORT
+/// This function is passed to libomptarget as part of the OMPT connector
----------------
We should be able to move the ifdef to the top. Let's keep it consistent with libomptarget.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070