[Openmp-commits] [PATCH] D143683: [openmp] Fix building z_Linux_asm.S for armv5t

Martin Storsjö via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Feb 9 14:43:06 PST 2023


mstorsjo created this revision.
mstorsjo added reviewers: DavidSpickett, tianshilei1992, sylvestre.ledru.
Herald added subscribers: guansong, kristof.beyls, yaxunl.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
Herald added a project: OpenMP.

Don't use the ldrd instruction; that one requires armv5te and
thumb2.

This should fix https://github.com/llvm/llvm-project/issues/60370.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143683

Files:
  openmp/runtime/src/z_Linux_asm.S


Index: openmp/runtime/src/z_Linux_asm.S
===================================================================
--- openmp/runtime/src/z_Linux_asm.S
+++ openmp/runtime/src/z_Linux_asm.S
@@ -1426,7 +1426,8 @@
 	// for when we call pkfn below
 	push	{r3-r11,lr}
 	// Load p_argv and &exit_frame
-	ldrd	r4, r5, [sp, #10*4]
+	ldr	r4, [sp, #10*4]
+	ldr	r5, [sp, #11*4]
 
 # if KMP_OS_DARWIN || (defined(__thumb__) && !KMP_OS_WINDOWS)
 # define FP r7


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143683.496244.patch
Type: text/x-patch
Size: 441 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230209/60d624af/attachment.bin>


More information about the Openmp-commits mailing list