[Openmp-commits] [PATCH] D143431: Switch the Windows OpenMP import library to import by name rather than ordinal.

[Vadim Paretsky via Phabricator via Openmp-commits]

vadikp-intel created this revision.
vadikp-intel added a reviewer: OpenMP.
vadikp-intel added a project: OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
vadikp-intel requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: openmp-commits, sstefan1.

The current OpenMP build script generates the Windows import library that imports by ordinal. This requires ordinal numbering coordination between contributors adding new APIs to the runtime and has in the past caused collisions requiring breaking changes to resolve them. Switching the library to import by name helps to avoid such collisions while also increasing compatibility between the different Windows versions of the OpenMP runtime (e.g. stock, MSVC's, etc.). The change keeps the existing ordinal ordering in the runtime to maintain compatibility of applications built with previous OpenMP releases. Note: due to incomplete 'llvm-lib' compatibility with 'lib' currently the solution only works with MSVC or ICC based Windows builds.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143431

Files:
  openmp/runtime/cmake/LibompMicroTests.cmake
  openmp/runtime/src/CMakeLists.txt
  openmp/runtime/tools/generate-def.pl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143431.495228.patch
Type: text/x-patch
Size: 6441 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230206/551655df/attachment.bin>