[Openmp-commits] [PATCH] D143192: [Libomptarget] Improve next-gen AMDGPU plugin error messages

[Kevin Sala via Phabricator via Openmp-commits]

kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:2460
+                           &Node) != HSA_STATUS_SUCCESS)
+      return HSA_STATUS_ERROR;
 
----------------
jhuber6 wrote:
> kevinsala wrote:
> > We could print the fatal message even if `hsa_agent_get_info` fails, right? We can print the GPU id or `unknown`/`unspecified` if the call failed.
> Yeah, we could probably just initialize it to `-1` and continue like nothing happened.
That's fine. We have to reinterpret the value as signed, or it will print the uint32_t's maximum value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143192/new/

https://reviews.llvm.org/D143192