[Openmp-commits] [PATCH] D143200: [OpenMP][libomp] Fix CMake version symbol testing

Jonathan Peyton via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Feb 2 09:40:44 PST 2023


jlpeyton created this revision.
jlpeyton added a reviewer: tianshilei1992.
jlpeyton added a project: OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
jlpeyton requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

Do not check for version symbol support if the necessary linker flag is not supported.

Fixes #60393


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143200

Files:
  openmp/runtime/cmake/config-ix.cmake


Index: openmp/runtime/cmake/config-ix.cmake
===================================================================
--- openmp/runtime/cmake/config-ix.cmake
+++ openmp/runtime/cmake/config-ix.cmake
@@ -246,7 +246,11 @@
 
 # Checking features
 # Check if version symbol assembler directives are supported
-libomp_check_version_symbols(LIBOMP_HAVE_VERSION_SYMBOLS)
+if (LIBOMP_HAVE_VERSION_SCRIPT_FLAG)
+  libomp_check_version_symbols(LIBOMP_HAVE_VERSION_SYMBOLS)
+else()
+  set(LIBOMP_HAVE_VERSION_SYMBOLS FALSE)
+endif()
 
 # Check if quad precision types are available
 if(CMAKE_C_COMPILER_ID STREQUAL "GNU")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143200.494341.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230202/57ed6297/attachment.bin>


More information about the Openmp-commits mailing list