[Openmp-commits] [openmp] [Libomptarget] Remove __tgt_image_info and use the ELF directly (PR #75720)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 18 13:02:35 PST 2023


jhuber6 wrote:

> > > Can we have tests for this patch?
> > 
> > 
> > The existing tests not breaking should be good enough. Testing the target-id stuff directly is difficult because it would depend on the platform you're running on.
> 
> Could we add one of those CHECK tests which looks at the output for AMD GPUs perhaps and make sure it emits what we expect? Not sure if that is feasible, just a thought.

Might be doable with unit tests in the future. We can just export more of this stuff as a single library.

https://github.com/llvm/llvm-project/pull/75720


More information about the Openmp-commits mailing list