[Openmp-commits] [openmp] [amdgpu] Default to 1.0, instead of unspecified, for dynamic hsa (PR #74098)

Jon Chesterfield via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 1 08:29:09 PST 2023


https://github.com/JonChesterfield created https://github.com/llvm/llvm-project/pull/74098

The plugin checks the values of HSA_AMD_INTERFACE_VERSION_* so we now set them to something safe in the header.

>From c7bbced5cb73949a53a224b788a5571df0524152 Mon Sep 17 00:00:00 2001
From: Jon Chesterfield <jonathanchesterfield at gmail.com>
Date: Fri, 1 Dec 2023 16:26:52 +0000
Subject: [PATCH] [amdgpu] Default to 1.0, instead of unspecified, for dynamic
 hsa

---
 .../plugins-nextgen/amdgpu/dynamic_hsa/hsa_ext_amd.h     | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/openmp/libomptarget/plugins-nextgen/amdgpu/dynamic_hsa/hsa_ext_amd.h b/openmp/libomptarget/plugins-nextgen/amdgpu/dynamic_hsa/hsa_ext_amd.h
index 188dd2600a610c6..9c59d3bf824de3c 100644
--- a/openmp/libomptarget/plugins-nextgen/amdgpu/dynamic_hsa/hsa_ext_amd.h
+++ b/openmp/libomptarget/plugins-nextgen/amdgpu/dynamic_hsa/hsa_ext_amd.h
@@ -14,6 +14,15 @@
 
 #include "hsa.h"
 
+/* Using this header means we do not know what version library will be linked.
+   Until such point as a CMake level override is requested, default to the
+   minimum. */
+/*
+ * - 1.0 - initial version
+ */
+#define HSA_AMD_INTERFACE_VERSION_MAJOR 1
+#define HSA_AMD_INTERFACE_VERSION_MINOR 0
+
 #ifdef __cplusplus
 extern "C" {
 #endif



More information about the Openmp-commits mailing list