[Openmp-commits] [PATCH] D159161: [openmp] Tighten flang detection in offloading test

Thu Aug 31 18:59:37 PDT 2023

elmcdonough added a comment.

In D159161#4633167 <https://reviews.llvm.org/D159161#4633167>, @jdoerfert wrote:

> In D159161#4628813 <https://reviews.llvm.org/D159161#4628813>, @elmcdonough wrote:
>
>> In D159161#4628422 <https://reviews.llvm.org/D159161#4628422>, @jdoerfert wrote:
>>
>>> didn't the docs say something about specifying a flang compiler via cmake? Is that still a thing?
>>
>> If you're building out of tree, you can specify where flang by setting `OPENMP_TEST_Fortran_COMPILER` manually.  The first version of this patch attempted to check if flang was present by reading the `LLVM_ENABLE_PROJECTS` value, but that didn't work as intended.  That value was always blank when the tests were being built.
>
> But will this not overwrite that flag and render it useless? I am confused.

This only applies if the project is built in-tree.  A compiler can be specified in a standalone build.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159161/new/

https://reviews.llvm.org/D159161