[Openmp-commits] [PATCH] D159119: [OpenMP] Enable optimization level for memory_manager.cpp OpenMP test.

Gheorghe-Teodor Bercea via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Aug 31 08:35:28 PDT 2023


doru1004 added a comment.

In D159119#4630718 <https://reviews.llvm.org/D159119#4630718>, @protze.joachim wrote:

> The test actually has an OpenMP issue:
>
> The memory is allocated on device 0, but no device is specified for the target region. I think, all target constructs should explicitly have a `device(0)` clause. At the moment, the test relies on implementation-defined behavior.

Added the additional device(0) clauses. This fixed the -O1 fails, I could no longer see intermittent fails with -O1 and with no optimization level the intermittent fails were significantly reduced to 1-2 in 500 tries whereas before there were 4-5 in every 100 tries. I will update the issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159119/new/

https://reviews.llvm.org/D159119



More information about the Openmp-commits mailing list