[Openmp-commits] [PATCH] D158802: [OpenMP] Honor `thread_limit` value when choosing grid size

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Aug 24 21:53:09 PDT 2023


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

See comment. LG



================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:424
       } else {
-        // Not enough parallelism for teams and threads, limit both.
-        NumThreads = std::min(NumThreads, MinThreads);
+        // Not enough parallelism for teams and threads, limit both NumThreads
+        // value is not from user.
----------------
jdoerfert wrote:
> 
With the change in the condition above, the old comment was good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158802/new/

https://reviews.llvm.org/D158802



More information about the Openmp-commits mailing list