[Openmp-commits] [PATCH] D157996: [OpenMP][OMPT] Fix reported target pointer for data alloc callback

Michael Halkenhäuser via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Aug 15 09:51:45 PDT 2023


mhalk created this revision.
mhalk added a reviewer: dhruvachak.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
mhalk requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: openmp-commits, jplehr, sstefan1.
Herald added a project: OpenMP.

This patch fixes: https://github.com/llvm/llvm-project/issues/64671
DataOp EMI callbacks would not report the correct target pointer.
This is now alleviated by passing a `void**` into the function which
emits the actual callback, then evaluating that pointer.

Note: Since this is only done after the pointer has been properly
updated, only `endpoint=2` callbacks will show a non-null value.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157996

Files:
  openmp/libomptarget/src/OmptCallback.cpp
  openmp/libomptarget/src/OmptInterface.h
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/test/ompt/veccopy_disallow_both.c
  openmp/libomptarget/test/ompt/veccopy_emi.c
  openmp/libomptarget/test/ompt/veccopy_emi_map.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157996.550373.patch
Type: text/x-patch
Size: 8751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230815/fb55c762/attachment.bin>


More information about the Openmp-commits mailing list