[Openmp-commits] [PATCH] D157918: [Libomptarget] Support mapping indirect host calls to device functions

[Ravi Narayanaswamy via Phabricator via Openmp-commits]

RaviNarayanaswamy added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/src/Misc.cpp:84
+
+  if (!Table || TableSize == 0)
+    return nullptr;
----------------
Do you want to check  if HstPtr is null  then return nullptr


================
Comment at: openmp/libomptarget/include/omptarget.h:95
+  /// Mark the entry global as being an indirectly callable function.
+  OMP_DECLARE_TARGET_INDIRECT = 0x04
 };
----------------
Should this be 0x08


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157918/new/

https://reviews.llvm.org/D157918