[Openmp-commits] [PATCH] D149010: [OpenMP] Fix GCC build issues and restore "Additional APIs used by the MSVC compiler for loop collapse (rectangular and non-rectangular loops)"

[Natalia Glagoleva via Phabricator via Openmp-commits]

natgla added inline comments.


================
Comment at: openmp/runtime/src/kmp_collapse.h:16
+
+#include <vector>
+#include <type_traits>
----------------
tianshilei1992 wrote:
> `vector` cannot be used here because it requires the standard C++ library. `libomp` is a C library *written in C++ syntax with header only STL*.
yes, realized that after the failures. It's strange the pre-commit build allows C++ runtime usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149010/new/

https://reviews.llvm.org/D149010