[Openmp-commits] [PATCH] D148178: [OpenMP][libomptarget] Improve plugin device info printing

[Kevin Sala via Phabricator via Openmp-commits]

kevinsala marked 2 inline comments as done.
kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h:146
+
+      fprintf(stdout, "%s%s:%s%s%s\n", std::string(KeyIndentLen, ' ').data(),
+              Entry.Key.data(), std::string(ValueIndentLen, ' ').data(),
----------------
jhuber6 wrote:
> tianshilei1992 wrote:
> > why not just `printf`?
> We could even use `llvm::outs()` if so inclined.
It looks cleaner with `llvm::outs()`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148178/new/

https://reviews.llvm.org/D148178