[Openmp-commits] [PATCH] D147511: [OpenMP] Fix nextgen plugin behavior when passing negative thread_limit clause

Wed Apr 19 09:33:01 PDT 2023

tianshilei1992 added a comment.

In D147511#4242785 <https://reviews.llvm.org/D147511#4242785>, @mhalk wrote:

> As far as I know: No, this patch should **avoid** exactly that case. (It seems that param would be set to `-1` when there's no `thread_limit` clause, which caused problems.)

I didn't see that is the case. https://godbolt.org/z/TdcfxfEej I didn't set the thread limit and then it is 0.
The spec says `thread_limit` has to be greater than zero. So here using 0 to indicate the clause is not set looks good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147511/new/

https://reviews.llvm.org/D147511