[Openmp-commits] [PATCH] D148027: [OpenMP][libomptarget] Remove error data member from AsyncInfoWrapperTy

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 accepted this revision.
jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:208
 
-Error AsyncInfoWrapperTy::finalize() {
+void AsyncInfoWrapperTy::finalize(Error &Err) {
   assert(AsyncInfoPtr && "AsyncInfoWrapperTy already finalized");
----------------
kevinsala wrote:
> jhuber6 wrote:
> > We need to explicitly discard this error now, otherwise it will abort the program when its destructor is called.
> But the error now is directly returned by each caller (e.g., `GenericDeviceTy::dataSubmit()`). Isn't that enough?
Oh, I see this is a **reference** to an `Error` presumably someone else handles its destruction? Guess that's allowed. Didn't read it fully, sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148027/new/

https://reviews.llvm.org/D148027