[Openmp-commits] [PATCH] D148178: [OpenMP][libomptarget] Improve plugin device info printing

Kevin Sala via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Apr 12 15:39:43 PDT 2023


kevinsala created this revision.
kevinsala added reviewers: jdoerfert, jhuber6, tianshilei1992.
kevinsala added a project: OpenMP.
Herald added subscribers: sunshaoce, kosarev, kerbowa, guansong, tpr, yaxunl, jvesely.
Herald added a project: All.
kevinsala requested review of this revision.
Herald added subscribers: openmp-commits, jplehr, sstefan1.

This patch improves the device info printing in the NextGen plugins. The device info properties are composed of keys and values, each property encapsulated by a `PrintInfoTy` object. These properties are pushed into a std::deque by each vendor-specific plugins, and later, processed and printed by the PluginInterface. This implementation extensively uses `std::string`, but it should not be a performance issue, since it's not in any critical path.

For the moment, this patch adds the device info for AMDGPU. It's missing the same changes for the CUDA plugin.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148178

Files:
  openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp
  openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp
  openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h
  openmp/libomptarget/plugins-nextgen/cuda/src/rtl.cpp
  openmp/libomptarget/plugins-nextgen/generic-elf-64bit/src/rtl.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148178.512988.patch
Type: text/x-patch
Size: 14653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230412/93dc3512/attachment.bin>


More information about the Openmp-commits mailing list