[Openmp-commits] [PATCH] D147756: [Libomptarget] Load an image if it is compatible with at least one device

Fri Apr 7 08:22:41 PDT 2023

tianshilei1992 added a comment.

In D147756#4251372 <https://reviews.llvm.org/D147756#4251372>, @estewart08 wrote:

> In D147756#4251325 <https://reviews.llvm.org/D147756#4251325>, @tianshilei1992 wrote:
>
>> What we currently have conservatively determines that a plugin is compatible to the image if all devices managed by the plugin are compatible. This is because when we initialize the device vector, we use a one-for-all style: if a plugin is compatible, we assume we can use all devices managed by the plugin. This patch will break the assumption.
>
> So if the system has a gfx908 and a gfx90a and --offload-arch=gfx908,gfx90a then it will say both images are not compatible because each image does not support both devices.

Yep, unfortunately that's the issue with current implementation. We have to fix it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147756/new/

https://reviews.llvm.org/D147756