[Openmp-commits] [PATCH] D134275: [OpenMP] [OMPD] Build gdb-plugin code only when python3 development files are available.

Tue Sep 20 23:29:55 PDT 2022

mgorny added inline comments.

================
Comment at: openmp/libompd/CMakeLists.txt:11-12

+set(LIBOMP_OMPD_GDB_SUPPORT FALSE CACHE BOOL
+        "Build gdb-plugin code that enables OMPD support in GDB.")
+
----------------
aaronpuchert wrote:
> Use `Python3_FOUND` (see [docs](https://cmake.org/cmake/help/latest/module/FindPython3.html#result-variables)).
I think `option()` is better for booleans.

https://cmake.org/cmake/help/latest/command/option.html

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134275/new/

https://reviews.llvm.org/D134275