[Openmp-commits] [PATCH] D128130: [libomptarget] Make libomptarget.devicertl.a built in all cases.

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Jun 18 19:31:26 PDT 2022


jhuber6 added a comment.

So this changes the compilation to just use the Clang binary found in the install directory and hope it works like we did previously. It's not ideal, I was planning on deleting all the code above and deprecating the old bitcode library. As I understand the reason we'd want to do this is to support compiling the OpenMP runtime with a different compiler than the `clang` that's necessary to build the device runtime. I wonder if instead it's possible to make the `RUNTIMES` portion of the build only apply to the device runtime, since realistically that's all we need it for.

Also with this method, we no longer inherit the `-DCMAKE_BUILD_TYPE=Release` and instead use the old `clang-opt-flags` which only did `-O1`. This removes a lot of the benefits users will see using this library for LTO over the traditional bitcode library. We don't do O3 <https://reviews.llvm.org/owners/package/3/> on the bitcode library because last I checked it broke everything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128130/new/

https://reviews.llvm.org/D128130



More information about the Openmp-commits mailing list