[Openmp-commits] [PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

John Ericson via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Jun 11 10:03:56 PDT 2022


Ericson2314 marked an inline comment as done.
Ericson2314 added inline comments.


================
Comment at: openmp/tools/CMakeLists.txt:1-3
+set(OPENMP_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE PATH
+    "Path for binary subdirectory (defaults to '${CMAKE_INSTALL_BINDIR}')")
+mark_as_advanced(OPENMP_TOOLS_INSTALL_DIR)
----------------
Ericson2314 wrote:
> protze.joachim wrote:
> > Is this variable used anywhere?
> `llvm_add_tool` computes a usage.
Moved this stuff make sure it is used properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117977/new/

https://reviews.llvm.org/D117977



More information about the Openmp-commits mailing list