[Openmp-commits] [PATCH] D112156: [OpenMP] Ensure broken assumptions print once, not thousands of times.

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Oct 25 15:17:45 PDT 2021


JonChesterfield accepted this revision.
JonChesterfield added inline comments.
This revision is now accepted and ready to land.


================
Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:263
+uint32_t atomic::exchange(uint32_t *Addr, uint32_t V, int Ordering) {
+  return impl::atomicExchange(Addr, V, Ordering);
+}
----------------
jdoerfert wrote:
> JonChesterfield wrote:
> > Normally takes two orderings
> No it does not. This is not cas.
Yep, thanks! Did indeed misread as compare&swap


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112156/new/

https://reviews.llvm.org/D112156



More information about the Openmp-commits mailing list