[Openmp-commits] [PATCH] D101213: [libomptarget] Enable AMDGPU devicertl

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D101213#2762248 <https://reviews.llvm.org/D101213#2762248>, @JonChesterfield wrote:

> In D101213#2762233 <https://reviews.llvm.org/D101213#2762233>, @tianshilei1992 wrote:
>
>> - The AMDGCN device runtime compilation fails because my Clang doesn't support AMDGCN backend. This failure can block the whole compilation of OpenMP.
>
> For what it's worth, that's a bug in clang that has been fixed. I guess it was introduced before the last release and fixed after, so there's a window of vulnerability there

I'm using the latest trunk, and I can still observe:

  [31/174] Generating sync.gfx900.bc
  FAILED: libomptarget/deviceRTLs/amdgcn/sync.gfx900.bc
  cd /nvm/0/shiltian/build/openmp/debug/libomptarget/deviceRTLs/amdgcn && /home/shiltian/.local/llvm-12.0.0/bin/clang -xc++ -c -std=c++14 -ffreestanding -target amdgcn-amd-amdhsa -emit-llvm -Xclang -aux-triple -Xclang x86_64-unknown-linux-gnu -fopenmp -fopenmp-cuda-mode -Xclang -fopenmp-is-device -D__AMDGCN__ -Xclang -target-cpu -Xclang gfx900 -fvisibility=default -Wno-unused-value -nogpulib -O2 -I/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/deviceRTLs/amdgcn/src -I/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/deviceRTLs/common/include -I/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/deviceRTLs /home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/deviceRTLs/common/src/sync.cu -o sync.gfx900.bc
  clang (LLVM option parsing): Unknown command line argument '--amdhsa-code-object-version=3'.  Try: 'clang (LLVM option parsing) --help'
  clang (LLVM option parsing): Did you mean '--pgo-memop-max-version=3'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101213/new/

https://reviews.llvm.org/D101213