[Openmp-commits] [PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon May 3 09:59:06 PDT 2021


JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

cstdlib may not exist, probably in the same situations as new not existing, but that can probably be left until the problem arises. I think this looks reasonable, and it'll unblock some applications that don't presently build.



================
Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:74
+  if (ptr)
+    ::free(ptr);
+}
----------------
free(nullptr) is well formed, don't think we need the branch here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100620/new/

https://reviews.llvm.org/D100620



More information about the Openmp-commits mailing list