[Openmp-commits] [PATCH] D106576: [OpenMP] Simplify the ThreadStackTy for globalization fallback

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

LGTM, passes previously failing tests now.

Two minor typos.



================
Comment at: openmp/libomptarget/deviceRTLs/common/src/data_sharing.cu:26
 struct alignas(32) ThreadStackTy {
-  static constexpr unsigned MaxSize = NThreads * BytesPerThread;
+  static constexpr unsigned BytesPerThread  BPerThread;
   static constexpr unsigned NumThreads = NThreads;
----------------



================
Comment at: openmp/libomptarget/deviceRTLs/common/src/data_sharing.cu:64-65
+EXTERN void __kmpc_free_shared(void *Ptr, size_t Bytes) {
+  size_t AlignedBytes = Bytes + (Bytes % MinBytes);
+  if (__kmpc_is_generic_main_thread(TID)) {
+    if (Ptr >= &MainSharedStack.Data[0][0] &&
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106576/new/

https://reviews.llvm.org/D106576