[Openmp-commits] [PATCH] D105955: [NFC][OpenMP][Offloading] Replaced explicit parallel level computation with function `__kmpc_parallel_level`

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 15 09:47:06 PDT 2021


tianshilei1992 added a comment.

In D105955#2876564 <https://reviews.llvm.org/D105955#2876564>, @JonChesterfield wrote:

> The function interface is clang internal, let's change it to take void instead of a couple of ignored arguments. That will slightly simplify clang codegen and means the pass that looks for and replaces calls to it doesn't have to consider arguments (the latter may work out of the box)

That's probably not working because as far as I can tell, we share some code generation with host code, but for host code, the two arguments are not ignored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105955/new/

https://reviews.llvm.org/D105955



More information about the Openmp-commits mailing list