[Openmp-commits] [PATCH] D95155: [libomptarget] Build cuda plugin without cuda installed locally

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Pretty much good to go. CMAKE variable, one potential change in the comment below, maybe name the declarations _v2.



================
Comment at: openmp/libomptarget/plugins/cuda/CMakeLists.txt:25
 
-include_directories(${LIBOMPTARGET_DEP_CUDA_INCLUDE_DIRS})
 include_directories(${LIBOMPTARGET_DEP_LIBELF_INCLUDE_DIRS})
 
----------------
JonChesterfield wrote:
> This probably warrants a variable to force one choice or the other, even if cuda is available on the system.
> 
> Also, not sure what the default should be when either option is available.
+1 for variable, default to use installed CUDA for now.


================
Comment at: openmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.cpp:63
+
+  const char *CudaLib = "libcuda.so";
+  void *dynlib_handle = dlopen(CudaLib, RTLD_NOW);
----------------
Should we make this a global, or a CMAKE variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95155/new/

https://reviews.llvm.org/D95155