[Openmp-commits] [PATCH] D96379: [OpenMP] Unify omptarget API and usage wrt. `__tgt_async_info`

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Feb 11 10:00:15 PST 2021


jdoerfert added a comment.

I'll update comments and the leftover sync.



================
Comment at: openmp/libomptarget/src/omptarget.cpp:1323-1324
   } else {
     // TODO: We should not synchronize here but on the outer level once we pass
-    // in a reference AsyncInfo object.
+    //       in a reference AsyncInfo object.
+    //
----------------
grokos wrote:
> So now this TODO (and the whole else-branch if I understand correctly) is ready to be removed, right? Synchronization takes place at the outer level (in `__tgt_target*`).
Yes, all this rebasing. I removed it before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96379/new/

https://reviews.llvm.org/D96379



More information about the Openmp-commits mailing list