[Openmp-commits] [PATCH] D115454: [OpenMP] Add "not" to test dependencies.

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny accepted this revision.
jdenny added a comment.

Other than the question I added inline, LGTM.



================
Comment at: openmp/cmake/OpenMPTesting.cmake:68
   endif()
   set(OPENMP_NOT_EXECUTABLE ${LLVM_RUNTIME_OUTPUT_INTDIR}/not)
 endif()
----------------
Do you know why `not` and `FileCheck` are handled differently here?  It might be that D95689 simply overlooked `not`.  @tianshilei1992?

I'm not sure if this discrepancy is relevant to the problem you're trying to fix, so maybe it should be addressed separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115454/new/

https://reviews.llvm.org/D115454