[Openmp-commits] [PATCH] D87980: [OpenMP] Protect unrecogonized CUDA error code

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.

In D87980#2285555 <https://reviews.llvm.org/D87980#2285555>, @jhuber6 wrote:

> In D87980#2285545 <https://reviews.llvm.org/D87980#2285545>, @tianshilei1992 wrote:
>
>> I also suggest to check `nullptr` before using `errStr`.
>
> I think the errStr is only NULL on when it returns CUDA_FAILURE so it would be redundant.

You're right. I double checked the CUDA document and it supports your comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87980/new/

https://reviews.llvm.org/D87980