[Openmp-commits] [PATCH] D87841: [openmp][libomptarget] Include header from LLVM source tree

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Sep 18 08:51:01 PDT 2020


jdoerfert added a comment.

In D87841#2281494 <https://reviews.llvm.org/D87841#2281494>, @grokos wrote:

> 4. At CMake time, check whether llvm-core is there; if yes use `OMPGridValues.h` from llvm-core, if no then download the header from some suitable location automatically. This eliminates the need for (2) and makes both proponents of (1) and proponents of (3) happy.

Most of our bigger machine have no internet. Download after the fact might also confuse people. I think telling the user to download and point to instead, as we do with other dependences, is in the grant scheme of things less surprising.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87841/new/

https://reviews.llvm.org/D87841



More information about the Openmp-commits mailing list