[Openmp-commits] [PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Looks generally good. We seem to have way to many places dealing with the mapping stuff but that is not your fault. One thing I found weird though:



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8078
+      for (auto LI = C->component_lists_begin(), LE = C->component_lists_end();
+           LI != LE; ++EI, ++LI) {
+        // The Expression is not correct if the mapping is implicit
----------------
Why iterations and not the range loop? also below


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8366
+                LE = MC->component_lists_end();
+           LI != LE; ++EI, ++LI) {
+        // The Expression is not correct if the mapping is implicit
----------------
same as above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89802/new/

https://reviews.llvm.org/D89802