[Openmp-commits] [PATCH] D88602: [libomptarget][amdgcn] Implement partial barrier

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

One nit. High level and going over the code looks reasonable, let's go with it.



================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:114
+
+DEVICE void __kmpc_impl_named_sync(uint32_t num_threads);
 
----------------
Add some (brief) documentation to the two methods please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88602/new/

https://reviews.llvm.org/D88602