[Openmp-commits] [PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

Tue Oct 6 16:09:21 PDT 2020

ye-luo added a comment.

In D88929#2315538 <https://reviews.llvm.org/D88929#2315538>, @jhuber6 wrote:

> In D88929#2315519 <https://reviews.llvm.org/D88929#2315519>, @ye-luo wrote:
>
>> Probably not messing with `enable_language(CUDA)` at the moment, just add `cuda_select_nvcc_arch_flags(CUDA_ARCH_FLAGS)` to  `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake?
>
> That only controls loading the library, since this is where we set all the CUDA options I think it's fine to call it here.

Yes. I'm reducing my review to libomptarget only. I could not comment on clang/CMakeLists.txt. Regarding libomptarget, keep all the CUDA detection inside `LibomptargetGetDependencies.cmake`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88929/new/

https://reviews.llvm.org/D88929