[Openmp-commits] [PATCH] D82245: [libomptarget] Add support for target update non-contiguous

Chi Chun Chen via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Nov 9 09:43:25 PST 2020


cchen added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:638
 
+static int target_data_contiguous(DeviceTy &Device, void *args_base,
+                                  void *HstPtrBegin, int64_t MapSize,
----------------
tianshilei1992 wrote:
> Since you're modifying this function, could you please change the coding style to LLVM style as well?
By coding style do you mean the name of the parameters? Can you be more specific? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82245/new/

https://reviews.llvm.org/D82245



More information about the Openmp-commits mailing list