[Openmp-commits] [PATCH] D77071: [libomptarget][nfc] Move non-freestanding headers out of common

Mon Mar 30 16:24:29 PDT 2020

jdoerfert added inline comments.

================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:21

+#include <assert.h>
+#include <inttypes.h>
----------------
JonChesterfield wrote:
> No stdio in amdgcn's target_impl as the only function used from it is printf, declared at the end of this header.
> 
> Can reduce amdgcn to wholly ffreestanding by providing an implementation of assert and two macros from inttypes, which may be a good idea as I think HIP is currently using the glibc versions of these headers for the device code.
I think this seems reasonable, depending on the macros.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77071/new/

https://reviews.llvm.org/D77071