[Openmp-commits] [PATCH] D82718: [OpenMP] Use primary context in CUDA plugin

Tue Jun 30 13:36:10 PDT 2020

ye-luo added a comment.

In D82718#2123675 <https://reviews.llvm.org/D82718#2123675>, @protze.joachim wrote:

> This patch drops the `CU_CTX_SCHED_BLOCKING_SYNC` property currently selected for the context. Is this intended? Should we add another function call to request this behavior for the primary context?

cuDevicePrimaryCtxSetFlags does allow me to set the flag. However, I don't have enough knowledge to say which flag CU_CTX_SCHED_BLOCKING_SYNC or not setting it, namely depends on the current PrimaryCtx flag.
I also don't feel right having libomptarget making a choice for all others.

My primary goal is to get the current issue fixed and get applications up and running.
If you prefer setting CU_CTX_SCHED_BLOCKING_SYNC to accept the patch, I can add that. It is not my primary concern and it is a separate topic and difficult.
There is no guarantee it will not be overwritten by another library or user code overwrites the flag for the primary context.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82718/new/

https://reviews.llvm.org/D82718