[Openmp-commits] [PATCH] D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D84996#2186441 <https://reviews.llvm.org/D84996#2186441>, @ye-luo wrote:

> Thanks for fixing the bug. It should be good for the moment.
> When I think about the existence of recursive mapper, we may still have more sync than needed. I think recursion the whole targetDataBegin/targetDataEnd is convenient but sub-optimal choice.
> Recursion should only be done on the map/mapper analysis. Just leave my thoughts here. It needs a discussion beyond this patch.

Recursive mapper does introduce a lot of synchronization overhead as it passes `nullptr` to those functions, therefore in the plugin, it will first fetch a new stream, enqueue the operation, and synchronize. The whole mapper is using "synchronous" operations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84996/new/

https://reviews.llvm.org/D84996