[Openmp-commits] [PATCH] D84816: [OpenMP] Refactored the function `target`

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added a comment.

Only minor documentation issues.



================
Comment at: openmp/libomptarget/src/omptarget.cpp:712
+namespace {
+/// Find the table information in the map or look it up in the translation
+/// tables.
----------------
If you know, could you document what table it is? There are many different tables in the code.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:768
 
-  // Move data to device.
+/// Process data before launching the kernel
+int processDataBefore(int64_t DeviceId, void *HostPtr, int32_t ArgNum,
----------------
Could you document more preciously what are processed and what are the output?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84816/new/

https://reviews.llvm.org/D84816