[Openmp-commits] [PATCH] D82963: [OpenMP] Temporarily disable failing runtime and ompt tests for OpenMP 5.0

Thu Jul 2 10:47:59 PDT 2020

saiislam added a comment.

In D82963#2128679 <https://reviews.llvm.org/D82963#2128679>, @Hahnfeld wrote:

> In D82963#2128507 <https://reviews.llvm.org/D82963#2128507>, @saiislam wrote:
>
> > Thanks @Hahnfeld. I realized that LLVM_MAJOR_VERSION was neither getting set in OpenMPTesting.cmake nor was it
> >  inheriting it from anywhere else. So, OPENMP_TEST_COMPILER_VERSION_MAJOR was also getting set as empty, which
> >  was getting propagated to lit by config.test_compiler_features. That is why "clang-11" was not getting recognized
> >  as a valid target by lit-unsupported (though clang-11.0.0 would have worked). This change should fix this issue.
>
>
> That's because the variable is called `LLVM_VERSION_MAJOR` (and it's been wrong since I added that code in 2017). I went ahead and fixed that mistake in https://github.com/llvm/llvm-project/commit/0e0483bf5c383d5815b9f945fea7e347d4badc0e. You shouldn't have to deal with broken infrastructure in this patch :)

Oh wow. So ultimately something good came out of it :-)
Thank you! I will update my patch in a few minutes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82963/new/

https://reviews.llvm.org/D82963