[Openmp-commits] [PATCH] D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off

Thu Jan 23 00:39:50 PST 2020

mgorny added a comment.

In D73249#1835526 <https://reviews.llvm.org/D73249#1835526>, @Hahnfeld wrote:

> I'm not sure `LIBOMP_OMPT_SUPPORT` is guaranteed to be there yet when defined in `runtime/`.

If by 'guaranteed' you mean in the current code, then I've tested this patch with it being both true and false.

> Maybe it would be better to move the option to the top-level `openmp/CMakeList.txt` and rename it to `OPENMP_OMPT_SUPPORT` (with compatibility support for `LIBOMP_OMPT_SUPPORT`)

I don't see a problem moving it. However, I'm not sure if rename is really desired. After all, AFAIU it's a characteristic of the library.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73249/new/

https://reviews.llvm.org/D73249