[Openmp-commits] [PATCH] D72525: [LIBOMPTARGET] Do not increment/decrement the refcount for "declare target" objects

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: openmp/libomptarget/src/device.h:54
+
+  inline long getRefCount() {
+    return RefCount;
----------------
You don't need inline here, it is inlined automatically, I assume, since defined in class.


================
Comment at: openmp/libomptarget/src/device.h:59
+  inline void setRefCount(long Value) {
+    if (!CONSIDERED_INF(RefCount))
+      RefCount = Value;
----------------
Maybe just use a bitfield/bool flag instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72525/new/

https://reviews.llvm.org/D72525