[Openmp-commits] [PATCH] D74837: [LIBOMPTARGET]Fix PR44933: fix crash because of the too early deinitialization of libomptarget.

Alexey Bataev via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Feb 19 13:03:33 PST 2020


ABataev added a comment.

In D74837#1883416 <https://reviews.llvm.org/D74837#1883416>, @grokos wrote:

> I understand the rationale behind this patch, although I haven't been able to reproduce the problem. Maybe we are just being proactive here and stay on the safe side before any problem actually occurs. I'll keep the review open for a while just in case someone wants to raise any concerns, but to me it looks good.


Did you try to run the test without this patch? For me, it crashes, just like the reproducer from the report


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74837/new/

https://reviews.llvm.org/D74837





More information about the Openmp-commits mailing list