[Openmp-commits] [PATCH] D74145: [OpenMP][Offloading] Added support for multiple streams so that multiple kernels can be executed concurrently

Tue Feb 11 20:04:40 PST 2020

jdoerfert added a comment.

In D74145#1871269 <https://reviews.llvm.org/D74145#1871269>, @tianshilei1992 wrote:

> In D74145#1871257 <https://reviews.llvm.org/D74145#1871257>, @grokos wrote:
>
> > The patch looks good to me. One final comment: is `LIBOMPTARGET_NUM_STREAMS` the most appropriate name for the new env var? Because it targets the CUDA plugin specifically, should we change the name to something like `LIBOMPTARGET_CUDA_NUM_STREAMS`?
>
>
> My idea is the concept of stream is widely used in different platforms. They might use different terminology.

Let's not complicate the name and just interpret "STREAMS" as whatever the equivalent of the platform is. That way we can have a single environment variable.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74145/new/

https://reviews.llvm.org/D74145