[Openmp-commits] [PATCH] D90962: [OpenMP] Fix possible NULL dereferences

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

In D90962#2426483 <https://reviews.llvm.org/D90962#2426483>, @jdoerfert wrote:

> LGTM, I left a nit inlined but feel free to ignore.
>
> ... 
>  Argh, ... OK, so the situation we are in is that the frontends are not in agreement. One thing we should avoid is to mix the comments in the runtime as well, will just cause more confusion. I'd argue we can let the frontends do what they think is right and in the runtime just say "this is a number that is either the line end or column". We always treat it the same, given that we don't interpret it anyway. Tools need to be aware of the frontend to avoid confusion. WDYT? (This would mean an action item to make sure all comments (maybe also variable names) reflect the duality.)

I've changed the type of init_fname parameter from int to bool; replaced names line_beg/line_end with line/col to be consistent with surrounding code; and changed parameter name LineEnd to LineEndOrCol, also adjusted comments on the definition of __kmp_str_loc_numbers to reflect the duality of the last field in location string.

Feel free to comment post-commit if needed.
Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90962/new/

https://reviews.llvm.org/D90962