[Openmp-commits] [PATCH] D86307: [OpenMP] Pack first-private arguments to improve efficiency of data transfer

Thu Aug 27 19:47:22 PDT 2020

tianshilei1992 marked an inline comment as done.
tianshilei1992 added inline comments.

================
Comment at: openmp/libomptarget/test/mapping/private_mapping.c:2
+// RUN: %libomptarget-compile-aarch64-unknown-linux-gnu
+// RUN: %libomptarget-run-fail-aarch64-unknown-linux-gnu 2>&1 \
+// RUN: | %fcheck-aarch64-unknown-linux-gnu
----------------
ABataev wrote:
> Why the test is marked as expected to fail? Is this intentional?
That is a mistake. Nice catch, thanks! I'll fix it in another patch. I copied this part from another file and didn't notice it is expected to fail. I did the test manually w/o `lit` so didn't observe this mistake. I'm wondering why the Buildkite didn't report any issue?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86307/new/

https://reviews.llvm.org/D86307