[Openmp-commits] [PATCH] D85742: [libomptarget] Implement host plugin for amdgpu

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Aug 12 07:29:37 PDT 2020


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/src/rtl.cpp:32
+    /* AMDGPU target  */ "libomptarget.rtl.amdgpu.so",
+};
 
----------------
Discussed in call that these should be in the order in which they were added to the codebase. Thus AMDGPU is at the end as the most recent addition.

Someone who knows this chronological order should reorder them separate to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85742/new/

https://reviews.llvm.org/D85742



More information about the Openmp-commits mailing list