[Openmp-commits] [PATCH] D85342: [OpenMP] Fix `target data` exit for array extension

Joel E. Denny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Aug 5 14:34:55 PDT 2020


jdenny added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:509
+                                              UpdateRef, IsHostPtr,
+                                              /*MustContain=*/true);
     if (!TgtPtrBegin && (DataSize || HasPresentModifier)) {
----------------
Ah, I broke reference count decrements for implicit mappings.  I think it should be `true` -> `!IsImplicit`.  I'll work on another patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85342/new/

https://reviews.llvm.org/D85342



More information about the Openmp-commits mailing list