[Openmp-commits] [PATCH] D85320: [OpenMP] Fix `present` diagnostic for array extension

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:194
     // Explicit extension of mapped data - not allowed.
     DP("Explicit extension of mapping is not allowed.\n");
+    if (HasPresentModifier)
----------------
grokos wrote:
> On second thoughts, maybe this should also become a MESSAGE. It's a diagnostic which will help the user understand why the present-related message follows.
Are you suggesting it generally or only when `HasPresentModifier`?


================
Comment at: openmp/libomptarget/src/device.cpp:197
+      MESSAGE("device mapping required by 'present' map type modifier does not "
+              "exist for host address " DPxMOD " (%ld bytes)",
+              DPxPTR(HstPtrBegin), Size);
----------------
vzakhari wrote:
> Can you please use PRId64 instead?  '%ld' tends to break Windows builds.
Thanks for catching that.  I'll fix this here and propose another patch to fix all the other places I made this mistake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85320/new/

https://reviews.llvm.org/D85320